[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virExec: avoid uninitialized memory usage



On 02/24/2011 12:59 PM, Jiri Denemark wrote:
> On Mon, Feb 21, 2011 at 14:35:23 -0700, Eric Blake wrote:
>> valgrind warns:
>>
>> ==21079== Syscall param rt_sigaction(act->sa_mask) points to uninitialised byte(s)
>> ==21079==    at 0x329840F63E: __libc_sigaction (sigaction.c:67)
>> ==21079==    by 0x4E5A8E7: __virExec (util.c:661)
>>
>> Regression introduced in commit ab07533e.  Technically, sa_mask
>> shouldn't affect operation if sa_flags selects sa_handler, and
>> sa_handler selects SIG_IGN, but better safe than sorry.

Not to mention that shutting up valgrind on spurious warnings makes it
easier to find the real ones.

> 
> Yeah, I agree. ACK.

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]