[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add check for kill() to fix build of cgroups on win32



On 02/28/2011 07:15 AM, Daniel P. Berrange wrote:
> The kill() function doesn't exist on Win32, so it needs to be
> checked for at build time & code disabled in cgroups
> 
> * configure.ac: Check for kill()
> * src/util/cgroup.c: Stub out virCGroupKill* functions
>   when kill() isn't available
> ---
>  configure.ac      |    2 +-
>  src/util/cgroup.c |   20 ++++++++++++++++++++
>  2 files changed, 21 insertions(+), 1 deletions(-)

Indeed, gnulib doesn't support kill for mingw yet.

> 
> diff --git a/configure.ac b/configure.ac
> index bd509f3..a58ee4e 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -120,7 +120,7 @@ AC_MSG_RESULT([$have_cpuid])
>  dnl Availability of various common functions (non-fatal if missing),
>  dnl and various less common threadsafe functions
>  AC_CHECK_FUNCS_ONCE([cfmakeraw regexec sched_getaffinity getuid getgid \
> - initgroups posix_fallocate mmap \
> + initgroups posix_fallocate mmap kill \
>   getmntent_r getgrnam_r getpwuid_r])

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]