[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Remove bashisms from libvirt-guests

On 12/25/2010 12:44 PM, Laurent Léonard wrote:
> Le lundi 20 décembre 2010 17:01:14, Eric Blake a écrit :
>> On 12/18/2010 04:51 AM, Laurent Léonard wrote:
>>>>> -    retval wait $virsh_pid && printf '\r%s%-12s\n' "$label" $"done"
>>>>> +    retval wait $virsh_pid && printf '\r%s%-12s\n' "$label" "`gettext
>>>>> \"done\"`"
>>>> Likewise: "$(gettext "done")"
>>>> But thanks for taking this on; we're getting closer to a nice solution.
>>> I followed:
>>> http://www.gnu.org/software/hello/manual/gettext/Preparing-Shell-Scripts.
>>> html but totally agree with your comments.
>> The gettext manual assumes that you are trying to be portable to all
>> sorts of /bin/sh, including Solaris's horribly-dated version that lacks
>> lots of POSIX features, hence it uses `` instead of $().  But for a
>> Linux init script, we can safely assume a decent POSIX shell.
> Any news about fixing those bashisms ?

I'm in favor of the ideas, but the patch isn't quite polished yet.  I've
been a bit short on time to clean the patch up myself, and was hoping
you would be willing to submit another version based on my comments from
the previous round.  But given the current goal of releasing 0.8.7 in
the very near future, I'm afraid this has missed the release deadline
and you will have to maintain it as a backport for another release cycle.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]