[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] build: avoid compilation warnings



Detected on cygwin:
util/util.c: In function 'virSetUIDGID':
util/util.c:2824: warning: format '%d' expects type 'int', but argument 7 has type 'gid_t' [-Wformat]
(and three other lines)

* src/util/util.c (virSetUIDGID): Cast, as is done elsewhere in
this file, to avoid printf type mismatch warnings.
---

Pushing under the build-breaker rule.

 src/util/util.c |   13 ++++++++-----
 1 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/src/util/util.c b/src/util/util.c
index 197c571..60feb79 100644
--- a/src/util/util.c
+++ b/src/util/util.c
@@ -1,7 +1,7 @@
 /*
  * utils.c: common, generic utility functions
  *
- * Copyright (C) 2006-2010 Red Hat, Inc.
+ * Copyright (C) 2006-2011 Red Hat, Inc.
  * Copyright (C) 2006 Daniel P. Berrange
  * Copyright (C) 2006, 2007 Binary Karma
  * Copyright (C) 2006 Shuveb Hussain
@@ -2822,7 +2822,8 @@ virSetUIDGID(uid_t uid, gid_t gid)
     if (gid > 0) {
         if (setregid(gid, gid) < 0) {
             virReportSystemError(errno,
-                                 _("cannot change to '%d' group"), gid);
+                                 _("cannot change to '%d' group"),
+                                 (unsigned int) gid);
             return -1;
         }
     }
@@ -2844,14 +2845,15 @@ virSetUIDGID(uid_t uid, gid_t gid)
         getpwuid_r(uid, &pwd, buf, bufsize, &pwd_result);
         if (!pwd_result) {
             virReportSystemError(errno,
-                                 _("cannot getpwuid_r(%d)"), uid);
+                                 _("cannot getpwuid_r(%d)"),
+                                 (unsigned int) uid);
             VIR_FREE(buf);
             return -1;
         }
         if (initgroups(pwd.pw_name, pwd.pw_gid) < 0) {
             virReportSystemError(errno,
                                  _("cannot initgroups(\"%s\", %d)"),
-                                 pwd.pw_name, pwd.pw_gid);
+                                 pwd.pw_name, (unsigned int) pwd.pw_gid);
             VIR_FREE(buf);
             return -1;
         }
@@ -2859,7 +2861,8 @@ virSetUIDGID(uid_t uid, gid_t gid)
 # endif
         if (setreuid(uid, uid) < 0) {
             virReportSystemError(errno,
-                                 _("cannot change to uid to '%d'"), uid);
+                                 _("cannot change to uid to '%d'"),
+                                 (unsigned int) uid);
             return -1;
         }
     }
-- 
1.7.3.4


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]