[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: avoid 'make syntax-check' failure



On Mon, Jan 03, 2011 at 09:27:58AM -0700, Eric Blake wrote:
> * cfg.mk (local-checks-to-skip): Add sc_copyright_check, since we
> don't use version-etc module.
> ---
> 
> This is the simpler variant that avoids a .gnulib update.  While
> gnulib has had a lot of recent fixes, most of them have been for
> HP-UX, Solaris, OSF/1, or Haiku (not primary targets of libvirt
> compilation at the moment), and many of the fixes are to modules not
> used by libvirt.  Do we want to go with this more minimalistic patch
> instead?
> 
>  cfg.mk |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/cfg.mk b/cfg.mk
> index 03186b3..539dbcb 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -1,5 +1,5 @@
>  # Customize Makefile.maint.                           -*- makefile -*-
> -# Copyright (C) 2003-2010 Free Software Foundation, Inc.
> +# Copyright (C) 2009-2011 Red Hat, Inc.
> +# Copyright (C) 2003-2010 Free Software Foundation, Inc.
> 
>  # This program is free software: you can redistribute it and/or modify
>  # it under the terms of the GNU General Public License as published by
> @@ -37,6 +37,7 @@ local-checks-to-skip =			\
>    sc_GPL_version			\
>    sc_always_defined_macros		\
>    sc_cast_of_alloca_return_value	\
> +  sc_copyright_check			\
>    sc_cross_check_PATH_usage_in_tests	\
>    sc_dd_max_sym_length			\
>    sc_error_exit_success			\

  I must admit I got confused, I locally patched dist.mk to avoid the
check but then the modification didn't show up on git status. Moreover
ssh and then git to libvirt.org wasn't working this morning from my
home (a routing problem because I could access from elsewhere) so I ended
up not pushing any patch specific to make syntax-check as part of libvirt
0.8.7 release. I think the right thing to do now is update gnulib (i.e.
previous patch) since the release is done.
  Also if you could tag v0.8.7 on my commit with your key that would be nice
(my master key is on a few hard drives but all in a box, in a container, on
a ship somewhere :-\ I had forgotten this !)

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]