[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] qemu driver: use lseek64 for setting position in logfile



On 01/04/2011 10:22 AM, Daniel P. Berrange wrote:
> On Tue, Jan 04, 2011 at 10:16:54AM -0700, Eric Blake wrote:
>> On 01/04/2011 09:43 AM, Stefan Berger wrote:
>>> V2:
>>>   - removed replacements of lseek() to lseek64() from patch
>>>
>>> While doing some testing with Qemu and creating huge logfiles I
>>> encountered the case where the VM could not start anymore due to the
>>> lseek() to the end of the Qemu VM's log file failing. The patch below
>>> fixes the problem by replacing the previously used 'int' with 'off_t'.
>>
>> ACK; please push :)
> 
> With a more accurate commit message now that its not
> using lseek64....

Oops - I was blinded to the inaccurate first line of the commit message,
since it's in the subject rather than the body of the mail :)

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]