[libvirt] Remove bashisms from libvirt-guests

Eric Blake eblake at redhat.com
Wed Jan 5 00:17:23 UTC 2011


On 01/04/2011 04:50 PM, Laurent Léonard wrote:
>> Here's what I'm planning on squashing in.  However, I still have one
>> nagging problem, that I haven't been able to figure out yet - even
>> though we listed libvirt-guests.init.in in po/POTFILES.in, xgettext
>> doesn't seem to be picking it up into po/libvirt.pot.  So until I can
>> figure that out, I'm holding off on pushing this just a bit longer.
> 
> Can you tell me what command line you are using to call xgettext ?
> 
> "xgettext -L Shell -o - tools/libvirt-guests.init.in" works fine.

Whatever command line is being produced automatically by the autotools.
 'make -B -C po libvirt.pot' shows it to be:

/usr/bin/xgettext --default-domain=libvirt --directory=.. \
  --add-comments=TRANSLATORS: --keyword=_ --keyword=N_
--flag=_:1:pass-c-format --flag=N_:1:pass-c-format
--flag=error:3:c-format --flag=error_at_line:5:c-format
--flag=virAsprintf:2:c-format --from-code=UTF-8
${end_of_xgettext_options+} \
  --files-from=./POTFILES.in \
  --copyright-holder='Red Hat, Inc.' \
  --msgid-bugs-address='libvir-list at redhat.com'
/usr/bin/xgettext: warning: file `tools/libvirt-guests.init.in'
extension `init' is unknown; will try C

Oh, that warning is a good hint.  Maybe if we rename the file
libvirt-guests.init.sh instead of .in, xgettext would be smart enough to
auto-detect it as Shell.  At which point, we'd have to tweak some
Makefile rules.  I'll play with that idea.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110104/0de6e4fc/attachment-0001.sig>


More information about the libvir-list mailing list