[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [TCK] [PATCH v2] Test cases for network ipv6 support



On 01/05/2011 01:10 AM, Laine Stump wrote:
On 01/04/2011 06:44 PM, Stefan Berger wrote:
v2:
  - added test cases using 'ip addr ...' and 'ip route ...' commands

This patch adds a couple of test cases for the recently added network ipv6 support.


I don't really feel qualified to do a good review of patches for libvirt-tck, but since you've taken the time to add in tests for code that I wrote, I felt it my responsibility to respond :-)

First - Thanks for adding this in!

Looks like I need to be careful where I run the libvirt-tck, as one of the networks chosen for testing will clobber the route to an important internal network (10.0.0.0/8) for the duration of the test.
We could choose the private network 172.16.0.0/12 instead, if that helps for most people.

Aside from that, and the indenting issue I mention below, it looks like these tests follow the pattern of previous network tests you've already committed, and they seem to be looking at the right things (although they seem a bit fragile - any change to the way we invoke radvd or dnsmasq will cause the test to fail, right?), so I would give a
Correct. In case of a change the tests would need to be adapted. Any suggestion on how this can be prevented are welcome.

conditional ACK (after fixing the indentation) just because more testing is better than less, if for no other reason :-)


Signed-off-by: Stefan Berger<stefanb us ibm com>


---
scripts/networks/networkxml2hostout/tck-testnet-3.dat | 39 +++++++++++++
 scripts/networks/networkxml2hostout/tck-testnet-3.post.dat |   14 ++++
scripts/networks/networkxml2xmlin/tck-testnet-3.xml | 22 +++++++
 3 files changed, 75 insertions(+)

Index: libvirt-tck/scripts/networks/networkxml2xmlin/tck-testnet-3.xml
===================================================================
--- /dev/null
+++ libvirt-tck/scripts/networks/networkxml2xmlin/tck-testnet-3.xml
@@ -0,0 +1,22 @@
+<network>
+<name>tck-testnet</name>
+<uuid>aadc8920-502a-4774-ac2b-cd382a204d06</uuid>
+<bridge name="tck-testbr" />
+<forward mode="nat" />
+<ip address="10.1.2.1" netmask="255.255.255.0">
+<dhcp>
+<range start="10.1.2.2" end="10.1.2.254" />
+<host mac="00:16:3e:77:e2:ed" name="a.example.com" ip="10.1.2.10" />
+<host mac="00:16:3e:3e:a9:1a" name="b.example.com" ip="10.1.2.11" />
+</dhcp>
+</ip>
+<ip family="ipv4" address="192.168.123.1" netmask="255.255.255.0">
+</ip>
+<ip family="ipv6" address="2001:db8:ac10:fe01::1" prefix="64">
+</ip>
+<ip family="ipv6" address="2001:db8:ac10:fd01::1" prefix="64">
+</ip>
+<ip family="ipv4" address="10.24.10.1">
+</ip>
+</network>
+

It might look nicer for this XML to be indented.

I will indent it.

   Stefan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]