[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: ensure --maximum flag used only with --config for setvcpus



On 14/01/2011, at 5:00 AM, Eric Blake wrote:
> Idiomatically, I would use || instead of | (although the result is the
> same in this case).
> 
> Also, rather than checking flags, you can check the bool variables that
> fed flags.  I'm squashing this in, then pushing.

Thanks Eric.  :)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]