[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] docs: clarify that virsh setvcpus and setmem only work on active domains

On 01/13/2011 11:27 AM, Justin Clift wrote:
> On 13/01/2011, at 8:54 AM, Eric Blake wrote:
>> On 01/12/2011 02:24 PM, Justin Clift wrote:
>>> Addresses BZ # 622534:
>>>  https://bugzilla.redhat.com/show_bug.cgi?id=622534
>>> ---
>>> tools/virsh.pod |   28 ++++++++++++++++++----------
>>> 1 files changed, 18 insertions(+), 10 deletions(-)
> <snip>
>> Do we need extra text talking about rounding and/or rejection if the
>> hypervisor can't support a memory limit with that small of a granularity
>> (for example, Matthias recently posted patches regarding esx only having
>> megabyte granularity).
> Hows this for the setmem virsh text?
> setmem domain-id new-allocation
>       Immediately change the current memory allocation for an active guest domain. The new-allocation value is in
>       kilobytes, and will be rejected if the hypervisor can't support the given memory allocation.
>       For vSphere/ESX, the new-allocation value must be a multiple of megabytes (ie. 2048 for 2GB), otherwise the
>       hypervisor will reject it.

Not quite.  The virsh command always takes kB, but vSphere rejects the
parameter unless the kB argument is evenly divisible by 1024 (that is,
the kB argument happens to represent megabytes).

Maybe more like:

Some hypervisors require a larger granularity than kilobytes, and
requests that are not an even multiple will either be rounded down or

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]