[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] Add HAP to virDomainFeature enum



On 01/13/2011 10:20 AM, Jim Fehlig wrote:
> Daniel P. Berrange wrote:
>> On Wed, Jan 05, 2011 at 04:32:39PM -0700, Jim Fehlig wrote:
>>   
>>> Extend the virDomainFeature enumeration to include HAP (hardware
>>> assisted paging) feature.
>>>
>>> Hardware features such as Extended Page Table and Nested Page
>>> Table augment hypervisor software techniques such as shadow
>>> page table.  Adding HAP to the virDomainFeature enumeration
>>> allows users to select between hardware and software memory
>>> management mechanisms for their guests.
>>> ---
>>>  src/conf/domain_conf.c |    3 ++-
>>>  src/conf/domain_conf.h |    1 +
>>>  2 files changed, 3 insertions(+), 1 deletions(-)
>>>     
>>
>> ACK
>>   
> 
> Thanks Daniel.  I've pushed this series now.

Unfortunately, this series is making 'make check' fail, like this:

57) Xen XM-2-XML Parse  pci-devs                                      ...
Expect [l]
Actual [hap = 0
l]

... FAILED
58) Xen XM-2-XML Format pci-devs                                      ... OK
FAIL: xmconfigtest

Can you work on a followup patch to adjust all the test .xm files to
account for the new "hap = 0" line?

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]