[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [RFC PATCHv2 2/5] qemu: move monitor device out of domain_conf common code



On Thu, Jan 13, 2011 at 05:34:34PM -0700, Eric Blake wrote:
> * src/conf/domain_conf.h (virDomainChrDeviceType): Drop monitor.
> * src/conf/domain_conf.c (virDomainChrDevice)
> (virDomainChrDefParseTargetXML, virDomainChrDefFormat): Drop
> monitor support.
> * src/qemu/qemu_command.h (qemuBuildCommandLine): Alter signature.
> * src/qemu/qemu_monitor.h (qemuMonitorOpen): Likewise.
> * src/qemu/qemu_domain.h (_qemuDomainObjPrivate): Change type of
> monConfig.
> * src/qemu/qemu_domain.c (qemuDomainObjPrivateFree)
> (qemuDomainObjPrivateXMLFormat, qemuDomainObjPrivateXMLParse):
> Adjust to type change.
> * src/qemu/qemu_command.c (qemuBuildCommandLine): Likewise.
> * src/qemu/qemu_driver.c (qemuPrepareMonitorChr)
> (qemudStartVMDaemon, qemuDomainXMLToNative, qemuConnectMonitor)
> (qemudShutdownVMDaemon): Likewise.
> * src/qemu/qemu_hotplug.c (qemuDomainAttachNetDevice): Likewise.
> * src/qemu/qemu_monitor.c (qemuMonitorOpen): Likewise.
> * tests/qemuxml2argvtest.c (testCompareXMLToArgvFiles): Likewise.
> ---
>  src/conf/domain_conf.c   |    9 ---------
>  src/conf/domain_conf.h   |    3 +--
>  src/qemu/qemu_command.c  |    7 +++----
>  src/qemu/qemu_command.h  |    2 +-
>  src/qemu/qemu_domain.c   |   29 ++++++++++++-----------------
>  src/qemu/qemu_domain.h   |    4 ++--
>  src/qemu/qemu_driver.c   |   23 ++++++++---------------
>  src/qemu/qemu_hotplug.c  |    4 ++--
>  src/qemu/qemu_monitor.c  |   10 +++++-----
>  src/qemu/qemu_monitor.h  |    4 ++--
>  tests/qemuxml2argvtest.c |    9 ++++-----
>  11 files changed, 40 insertions(+), 64 deletions(-)

ACK

Daniel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]