[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] qemu: improve device flag parsing



> * src/qemu/qemu_capabilities.h (qemuCapsParseDeviceStr): New
> prototype.
> * src/qemu/qemu_capabilities.c (qemuCapsParsePCIDeviceStrs)
> Rename and split...
> (qemuCapsExtractDeviceStr, qemuCapsParseDeviceStr): ...to make it
> easier to add and test device-specific checks.
> (qemuCapsExtractVersionInfo): Update caller.
> * tests/qemuhelptest.c (testHelpStrParsing): Also test parsing of
> device-related flags.
> (mymain): Update expected flags.
> * tests/qemuhelpdata/qemu-0.12.1-device: New file.
> * tests/qemuhelpdata/qemu-kvm-0.12.1.2-rhel60-device: New file.
> * tests/qemuhelpdata/qemu-kvm-0.12.3-device: New file.
> * tests/qemuhelpdata/qemu-kvm-0.13.0-device: New file.
> ---
>  src/qemu/qemu_capabilities.c                       |   41 ++++++++---
>  src/qemu/qemu_capabilities.h                       |    2 +
>  tests/qemuhelpdata/qemu-kvm-0.12.1.2-rhel60-device |   57 ++++++++++++++++
>  tests/qemuhelpdata/qemu-kvm-0.13.0-device          |   70 ++++++++++++++++++++
>  tests/qemuhelptest.c                               |   48 ++++++++++----
>  5 files changed, 195 insertions(+), 23 deletions(-)
>  create mode 100644 tests/qemuhelpdata/qemu-0.12.1-device
>  create mode 100644 tests/qemuhelpdata/qemu-kvm-0.12.1.2-rhel60-device
>  create mode 100644 tests/qemuhelpdata/qemu-kvm-0.12.3-device
>  create mode 100644 tests/qemuhelpdata/qemu-kvm-0.13.0-device

Nice and clean, thanks.

I think this can be pushed without test data for qemu-0.12.1 and
qemu-kvm-0.12.3. The -device files for them can be filled with data later.

ACK

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]