[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] Add HAP to virDomainFeature enum



Eric Blake wrote:
> On 01/13/2011 10:20 AM, Jim Fehlig wrote:
>   
>> Daniel P. Berrange wrote:
>>     
>>> On Wed, Jan 05, 2011 at 04:32:39PM -0700, Jim Fehlig wrote:
>>>   
>>>       
>>>> Extend the virDomainFeature enumeration to include HAP (hardware
>>>> assisted paging) feature.
>>>>
>>>> Hardware features such as Extended Page Table and Nested Page
>>>> Table augment hypervisor software techniques such as shadow
>>>> page table.  Adding HAP to the virDomainFeature enumeration
>>>> allows users to select between hardware and software memory
>>>> management mechanisms for their guests.
>>>> ---
>>>>  src/conf/domain_conf.c |    3 ++-
>>>>  src/conf/domain_conf.h |    1 +
>>>>  2 files changed, 3 insertions(+), 1 deletions(-)
>>>>     
>>>>         
>>> ACK
>>>   
>>>       
>> Thanks Daniel.  I've pushed this series now.
>>     
>
> Unfortunately, this series is making 'make check' fail, like this:
>   

Hmm, a bug in my test scripts caused me to miss this.  Looking at logs
make check actually failed for me here:

  CC     secaatest.o
cc1: warnings being treated as errors
secaatest.c: In function 'main':
secaatest.c:18:5: error: implicit declaration of function
'virSecurityDriverStartup' [-Wimplicit-function-declaration]
secaatest.c:18:5: error: nested extern declaration of
'virSecurityDriverStartup' [-Wnested-externs]
secaatest.c:28:13: error: expected expression before
'virSecurityDriverGetModel'
secaatest.c:36:11: error: expected expression before
'virSecurityDriverGetDOI'


> 57) Xen XM-2-XML Parse  pci-devs                                      ...
> Expect [l]
> Actual [hap = 0
> l]
>
> ... FAILED
> 58) Xen XM-2-XML Format pci-devs                                      ... OK
> FAIL: xmconfigtest
>
> Can you work on a followup patch to adjust all the test .xm files to
> account for the new "hap = 0" line?
>   
Yes.

Regards,
Jim


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]