[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 3/4] qemu: Support per-device boot ordering



On 01/14/2011 10:04 AM, Jiri Denemark wrote:
> Support for this is included in qemu and seabios from upstream git.
> 
> ---
> Notes:
>     Version 2:
>     - support for floppy devices
>     - rebased on top of Eric's capabilities changes

> diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
> index 8057479..e9e2da0 100644
> --- a/src/qemu/qemu_capabilities.h
> +++ b/src/qemu/qemu_capabilities.h
> @@ -83,6 +83,7 @@ enum qemuCapsFlags {
>      QEMUD_CMD_FLAG_SPICE         = (1LL << 46), /* Is -spice avail */
>      QEMUD_CMD_FLAG_VGA_NONE      = (1LL << 47), /* The 'none' arg for '-vga' */
>      QEMUD_CMD_FLAG_MIGRATE_QEMU_FD = (1LL << 48), /* -incoming fd:n */
> +    QEMUD_CMD_FLAG_BOOTINDEX     = (1LL << 49), /* -device bootindex property */

Lots of us wanting to touch this file lately - whoever commits second
better remember to resolve the conflict correctly :)

Overall, looks good to me (unless I'm overlooking something about qemu
behavior that Dan is more familiar with).

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]