[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix 'make check' after commit 04197350



Eric Blake wrote:
> On 01/14/2011 11:29 AM, Jim Fehlig wrote:
>   
>> I broke 'make check' with commit 04197350 by unconditionally
>> emitting 'hap=' in xen xm driver.  Only emit 'hap=' if
>> xendConfigVersion >= 3.  I've tested sending 'hap=' to a Xen 3.2
>> machine without support for hap setting and verified that xend
>> silently drops the unrecognized setting.
>> ---
>>  src/xen/xm_internal.c |    9 +++++----
>>  1 files changed, 5 insertions(+), 4 deletions(-)
>>     
>
> ACK; fixes 'make check' for me, and nicer than having to tweak ever
> version-2 .xm file in the test directory to add the new hap = 0 line.
>   

Thank; pushed now.  Apologies for not noticing the make check failure
beforehand.

Regards,
Jim


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]