[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] Use the new set_password monitor command to set password.



On Mon, Jan 10, 2011 at 12:12:33PM +0100, Marc-André Lureau wrote:
> From: Marc-André Lureau <marcandre lureau redhat com>
> 
> We try to use that command first when setting a VNC/SPICE password. If
> that doesn't work we fallback to the legacy VNC only password
> 
> Allow an expiry time to be set, if that doesn't work, throw an error
> if they try to use SPICE.
> 
> Change since v1:
> - moved qemuInitGraphicsPasswords to qemu_hotplug, renamed
>   to qemuDomainChangeGraphicsPasswords.
> - updated what looks like a typo (that appears to work anyway) in
>   initial patch from Daniel:
>     - ret = qemuInitGraphicsPasswords(driver, vm,
>     -                                 VIR_DOMAIN_GRAPHICS_TYPE_SPICE,
>     -                                 &vm->def->graphics[0]->data.vnc.auth,
>     -                                 driver->vncPassword);
>     + ret = qemuInitGraphicsPasswords(driver, vm,
>     +                                 VIR_DOMAIN_GRAPHICS_TYPE_SPICE,
>     +                                 &vm->def->graphics[0]->data.spice.auth,
>     +                                 driver->spicePassword);
> 
> Based on patch by Daniel P. Berrange <berrange redhat com>.
> ---
>  src/qemu/qemu_driver.c  |   22 +++++----
>  src/qemu/qemu_hotplug.c |  114 +++++++++++++++++++++++++++++++++++++++++++---
>  src/qemu/qemu_hotplug.h |    5 ++
>  3 files changed, 123 insertions(+), 18 deletions(-)


ACK


Daniel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]