[libvirt] [PATCH] qemu: Error prompt if invalid dump image format specified
Daniel P. Berrange
berrange at redhat.com
Mon Jan 17 12:03:45 UTC 2011
On Mon, Jan 17, 2011 at 12:39:21PM +0800, Osier Yang wrote:
> "getCompressionType" trys to throw error when invalid dump image
> format is specified, or the compression program for the specified
> image format is not available, but at the same time, it returns
> enum qemud_save_formats, as a result, upper function will think
> it was successful, and disgard to check the error, this fix makes
> changes so that it returns -1 on FAILURE, And to be consistent with
> "save", won't use "raw" as the default dump format anymore.
>
> * src/qemu/qemu_driver.c
> - rename "getCompressionType" to "getDumpType"
> - return -1 on FAILURE
ACK
Daniel
More information about the libvir-list
mailing list