[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 6/7] qemu: use lighter-weight fd:n on incoming tunneled migration



On 01/14/2011 09:48 PM, Eric Blake wrote:
Outgoing migration still has to use a Unix socket and or exec netcat,
since there is no way to pass a migration fd into qemu via monitor
commands, but incoming migration need not suffer from the complexity.

* src/qemu/qemu_driver.c (qemudDomainMigratePrepareTunnel):
Replace Unix socket with simpler pipe.
Suggested by Paolo Bonzini.
---

I've since been corrected; qemu_monitor.c has qemuMonitorIOWriteWithFD
that looks like it can be used to avoid exec: on outgoing migrations
by instead passing an open fd over a unix socket, although I have not
tested that yet.  However, this patch does not need to be held up by
waiting for the followup patch that optimizes outgoing migrations.

  src/qemu/qemu_driver.c |   49 +++++++++++++++--------------------------------
  1 files changed, 16 insertions(+), 33 deletions(-)

Agreed, ACK.

Paolo


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]