[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: don't fail capabilities check on 0.12.x



On 01/18/2011 02:00 PM, Matthias Bolte wrote:
> 2011/1/18 Eric Blake <eblake redhat com>:
>> Fixes regression introduced in commit 2211518, where all qemu 0.12.x
>> fails to start, as does qemu 0.13.x lacking the pci-assign device.
>>
>> * src/qemu/qemu_capabilities.c (qemuCapsExtractVersionInfo): Check
>> for -device driver,? support.
>> (qemuCapsExtractDeviceStr): Avoid failure if all probed devices
>> are unsupported.
>> Reported by Ken Congyang.
>> ---
> 
> ACK.

Thanks; pushed.  I expanded the commit message a bit for clarity:

    Fixes regression introduced in commit 2211518, where all qemu 0.12.x
    fails to start, as does qemu 0.13.x lacking the pci-assign device.
    Prior to 2211518, the code was just ignoring a non-zero exit status
    from the qemu child, but the virCommand code checked this to avoid
    masking any other issues, which means the real bug of provoking
    non-zero exit status has been latent for a longer time.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]