[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Fail if per-device boot is used but deviceboot is not supported



On Wed, Jan 19, 2011 at 07:48:13 -0700, Eric Blake wrote:
> On 01/19/2011 07:07 AM, Jiri Denemark wrote:
> > ---
> >  src/qemu/qemu_command.c |    7 +++++++
> >  1 files changed, 7 insertions(+), 0 deletions(-)
> > 
> > diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> > index 24acc10..537e537 100644
> > --- a/src/qemu/qemu_command.c
> > +++ b/src/qemu/qemu_command.c
> > @@ -2949,6 +2949,13 @@ qemuBuildCommandLine(virConnectPtr conn,
> >              }
> >  
> >              virCommandAddArgBuffer(cmd, &boot_buf);
> > +        } else if (!(qemuCmdFlags & QEMUD_CMD_FLAG_BOOTINDEX)) {
> > +            /* def->os.nBootDevs is guaranteed to be > 0 unless per-device boot
> > +             * configuration is used
> > +             */
> > +            qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> > +                            _("hypervisor lacks deviceboot feature"));
> > +            goto error;
> >          }
> 
> ACK.

Pushed, thanks.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]