[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Avoid sending STOPPED event twice



On Wed, Jan 19, 2011 at 19:35:32 +0000, Daniel P. Berrange wrote:
> On Wed, Jan 19, 2011 at 08:19:36PM +0100, Jiri Denemark wrote:
> > In some circumstances, libvirtd would issue two STOPPED events after it
> > stopped a domain. This was because an EOF event can arrive after a qemu
> > process is killed but before qemuMonitorClose() is called.
> > 
> > qemuHandleMonitorEOF() should ignore EOF when the domain is not running.
> > 
> > I wasn't able to reproduce this bug directly, only after adding an
> > artificial sleep() into qemudShutdownVMDaemon().
> 
> That sounds reasonable - it would definitely be a race condition
> if it occurred, so sleep() would be expected to trigger it more
> often.
> 
> ACK

Thanks, pushed.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]