[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [RFD] Add/Modify some API functions about Host Information



On 01/20/2011 05:13 AM, Daniel P. Berrange wrote:
>>   * virSysinfoRead()
>>     This API is completely internal.
>>     But DMI type1 information(dmidecode -t1) is useful for above
>>     purpose, because it's one of the information which suppose to
>>     processing capacity about host machine.
>>     
>>     I want to export virSysinfoRead() to user.
> 
> I wouldn't want to export the API, because that would require
> us to expose some complex structures in the public ABI. I
> think we'd just want to expose the data in the host capabilities
> XML, or have an API to query the XML of just the sysinfo on its
> own.

You are not the first person to request some way of getting at the
host's sysinfo from a libvirt API, so the idea of exporting something
makes sense (just not virSysinfoRead in its current form).  Personally,
I like the idea of:

char *virConnectGetSysinfo(virConnectPtr)

which returns just the XML <sysinfo> block for a given host.  Also,
including <sysinfo> in the larger XML of virCopnnectGetCapabilities()
makes sense.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]