[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4] qemu: sound: Support intel 'ich6' model



On 01/24/2011 09:15 AM, Cole Robinson wrote:
> The important thing is to keep a consistent API here, we don't want some
> <sound> devs require tweaking codecs but not others. Steps I see to
> accomplishing this:
> 
>     - every <sound> device has a <codec type='default'/> (unless codecs are
>         manually specified)
>     - <codec type='none'/> is required to specify 'no codecs'
>     - new audio settings like mic=on|off could then be exposed in
>         <sound> or <codec> in a consistent manner for all sound models
> 
> v2:
>     Use model='ich6'
> 
> v3:
>     Use feature detection, from eblake
>     Set codec id, bus, and cad values
> 
> v4:
>     intel-hda isn't supported if -device isn't available

But still no typo fixes.

> -    /* Hack for 2 wierdly unusal devices name in QEMU */
> +    /* Hack for wierdly unusal devices name in QEMU */

(see my review at
https://www.redhat.com/archives/libvir-list/2011-January/msg00929.html)

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]