[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/1] Do not use virtio-serial port 0 for generic ports



On 01/24/2011 01:57 PM, David Allan wrote:
> Per the discussion in:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=670394
> 
> The port numbering should start from 1, not 0.  We assign maxport + 1,
> so start maxport at 0.
> ---
>  src/conf/domain_conf.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index d5445a4..08c21e5 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -5328,7 +5328,7 @@ static virDomainDefPtr virDomainDefParseXML(virCapsPtr caps,
> 
>          if (chr->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_SERIAL &&
>              chr->info.addr.vioserial.port == 0) {
> -            int maxport = -1;
> +            int maxport = 0;

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]