[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] docs: add a link to the bindings page under the downloads menu item



On Wed, Jan 26, 2011 at 04:22:07PM +1100, Justin Clift wrote:
> On 26/01/2011, at 4:14 PM, Justin Clift wrote:
> > On 26/01/2011, at 4:14 PM, Eric Blake wrote:
> >> On 01/25/2011 10:07 PM, Justin Clift wrote:
> >>> For people looking to download the language bindings, that don't know
> >>> they're under the "Docs" area.
> >>> ---
> >>> docs/sitemap.html.in |    4 ++++
> >>> 1 files changed, 4 insertions(+), 0 deletions(-)
> >>> 
> >>> diff --git a/docs/sitemap.html.in b/docs/sitemap.html.in
> >>> index bcce62f..c987c49 100644
> >>> --- a/docs/sitemap.html.in
> >>> +++ b/docs/sitemap.html.in
> >>> @@ -30,6 +30,10 @@
> >>>            <a href="windows.html">Windows</a>
> >>>            <span>Downloads for Windows</span>
> >>>          </li>
> >>> +          <li>
> >>> +            <a href="bindings.html">Language bindings</a>
> >>> +            <span>Bindings of the libvirt API for languages other than C</span>
> >>> +          </li>
> >> 
> >> ACK.
> > 
> > Thanks Eric, pushed.
> 
> Interesting side effect.  When a person clicks on the "Language bindings" entry now,
> both of the Downloads and Documentation entries are expanded and highlighted.
> 
> Doesn't look unworkably bad, but we should probably adjust the javascript at some
> point. :)

This isn't done with javascript, it is auto-generated HTML at
build time, based on the sitemap. IMHO the page should only
be located in one place on the site, so if we want it under
downloads, then remove it from documentation.

Regards,
Daniel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]