[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3 2/5] smartcard: add domain conf support



On Tue, Jan 25, 2011 at 05:36:55PM -0700, Eric Blake wrote:
> * src/conf/domain_conf.h (virDomainSmartcardType): New enum.
> (virDomainSmartcardDef, virDomainDeviceCcidAddress): New structs.
> (virDomainDef): Include smartcards.
> (virDomainSmartcardDefIterator): New typedef.
> (virDomainSmartcardDefFree, virDomainSmartcardDefForeach): New
> prototypes.
> (virDomainControllerType, virDomainDeviceAddressType): Add ccid
> enum values.
> (virDomainDeviceInfo): Add ccid address type.
> * src/conf/domain_conf.c (virDomainSmartcard): Convert between
> enum and string.
> (virDomainSmartcardDefParseXML, virDomainSmartcardDefFormat)
> (virDomainSmartcardDefFree, virDomainDeviceCcidAddressParseXML)
> (virDomainDefMaybeAddSmartcardController): New functions.
> (virDomainDefParseXML): Parse the new XML.
> (virDomainDefFormat): Convert back to XML.
> (virDomainDefFree): Clean up.
> (virDomainDeviceInfoIterate): Iterate over passthrough aliases.
> (virDomainController, virDomainDeviceAddress)
> (virDomainDeviceInfoParseXML, virDomainDeviceInfoFormat)
> (virDomainDefAddImplicitControllers): Support new values.
> * src/libvirt_private.syms (domain_conf.h): New exports.
> * cfg.mk (useless_free_options): List new function.
> 
> Notes:
>     v2: first version of patch (v1 was xml proposal only)
>     v3: add controller type='ccid' support, extra smartcard element support
> ---
>  cfg.mk                   |    1 +
>  src/conf/domain_conf.c   |  396 ++++++++++++++++++++++++++++++++++++++++++++--
>  src/conf/domain_conf.h   |   53 ++++++-
>  src/libvirt_private.syms |    4 +
>  4 files changed, 442 insertions(+), 12 deletions(-)

ACK

Daniel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]