[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Don't try to change max-memory of an active domain



On 28/01/2011, at 8:56 AM, Eric Blake wrote:
> On 01/27/2011 02:35 PM, Matthias Bolte wrote:
>> Report an VIR_ERR_OPERATION_INVALID error in that case instead of letting
>> the SOAP call fail with an VIR_ERR_INTERNAL_ERROR error.
>> ---
>> src/esx/esx_driver.c |   21 ++++++++++++++++++---
>> 1 files changed, 18 insertions(+), 3 deletions(-)
> 
> ACK.

Just as an interesting data point, the Xen driver also lets the max memory changing
function be called on active domains.  In the Xen case, it indicates an error, but
actually changes the "running" configs' XML value, losing the change when the domain
is then shut down.  It means a user can bump up the "max" value for the running domain,
then (without error) bump up the "currentMemory" value to match.  It just doesn't actually
do anything though... the domain doesn't seem to get the extra ram.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]