[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/5] Fix leak of 'msg' object in client stream code



On 07/08/2011 05:57 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> In one exit path we forgot to free the virNetMessage object causing
> a large memory leak for streams which send alot of data. Some other

s/alot/a lot/

> paths were calling VIR_FREE directly instead of virNetMessageFree
> although this was (currently) harmless.
> 
> * src/rpc/virnetclientstream.c: Fix leak of msg object
> * src/rpc/virnetclientprogram.c: Call virNetMessageFree instead
>   of VIR_FREE
> ---
>  src/rpc/virnetclientprogram.c |    4 ++--
>  src/rpc/virnetclientstream.c  |    3 ++-
>  2 files changed, 4 insertions(+), 3 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]