[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/5] Fix sending of reply to final RPC message



On 07/08/2011 05:57 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The dispatch for the CLOSE RPC call was invoking the method
> virNetServerClientClose(). This caused the client connection
> to be immediately terminated. This meant the reply to the
> final RPC message was never sent. Prior to the RPC rewrite
> we merely flagged the connection for closing, and actually
> closed it when the next RPC call dispatch had completed.
> 
> * daemon/remote.c: Flag connection for a delayed close
> * daemon/stream.c: Update to use new API for closing
>   failed connection
> * src/rpc/virnetserverclient.c, src/rpc/virnetserverclient.h:
>   Add support for a delayed connection close. Rename the
>   virNetServerClientMarkClose method to virNetServerClientImmediateClose
>   to clarify its semantics
> ---
>  daemon/remote.c              |    4 ++--
>  daemon/stream.c              |    6 +++---
>  src/rpc/virnetserverclient.c |   13 ++++++++++++-
>  src/rpc/virnetserverclient.h |    5 +++--
>  4 files changed, 20 insertions(+), 8 deletions(-)
> 

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]