[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add domain type checking



On 07/11/2011 03:32 PM, Eric Blake wrote:
>>>> +#include <math.h>
>>>
>>> What was this needed for?
>>
>> For log2 to convert 1 << x back to x in case only one bit is set in
>> expectedVirtTypes.
> 
> log2(), including -lm, is rather heavyweight.  It should be possible to
> use ffs() from <strings.h> to do the same thing, and then we don't have
> to worry about dragging in -lm.
> 
> I'll work up a patch tomorrow, if no one beats me to it tonight.

Done:

https://www.redhat.com/archives/libvir-list/2011-July/msg00598.html

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]