[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [Matahari] [libvirt-qpid PATCH 2/3] Convert class names to lower case



On Wed, Jul 13, 2011 at 2:29 AM, Zane Bitter <zbitter redhat com> wrote:
> This schema change is necessary to ensure that classes keep the same names
> after changing from the QMF to the QMFv2 API.

Odd.  But if you say so, ACK :-)

> ---
>  src/DomainWrap.cpp     |    2 +-
>  src/NodeWrap.cpp       |    2 +-
>  src/PoolWrap.cpp       |    2 +-
>  src/VolumeWrap.cpp     |    2 +-
>  src/libvirt-schema.xml |    8 ++++----
>  5 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/src/DomainWrap.cpp b/src/DomainWrap.cpp
> index eab6bbc..a72d970 100644
> --- a/src/DomainWrap.cpp
> +++ b/src/DomainWrap.cpp
> @@ -12,7 +12,7 @@ DomainWrap::DomainWrap(
>         virDomainPtr domain_ptr,
>         virConnectPtr conn):
>     PackageOwner<NodeWrap::PackageDefinition>(parent),
> -    ManagedObject(package().data_Domain),
> +    ManagedObject(package().data_domain),
>     _domain_ptr(domain_ptr), _conn(conn)
>  {
>     char dom_uuid[VIR_UUID_STRING_BUFLEN];
> diff --git a/src/NodeWrap.cpp b/src/NodeWrap.cpp
> index d65db11..40c4339 100644
> --- a/src/NodeWrap.cpp
> +++ b/src/NodeWrap.cpp
> @@ -16,7 +16,7 @@
>
>
>  NodeWrap::NodeWrap(qmf::AgentSession& agent_session, PackageDefinition& package):
> -    ManagedObject(package.data_Node),
> +    ManagedObject(package.data_node),
>     _session(agent_session),
>     _package(package)
>  {
> diff --git a/src/PoolWrap.cpp b/src/PoolWrap.cpp
> index a5992f2..dee2597 100644
> --- a/src/PoolWrap.cpp
> +++ b/src/PoolWrap.cpp
> @@ -13,7 +13,7 @@ PoolWrap::PoolWrap(NodeWrap *parent,
>                    virStoragePoolPtr pool_ptr,
>                    virConnectPtr connect):
>     PackageOwner<NodeWrap::PackageDefinition>(parent),
> -    ManagedObject(package().data_Pool),
> +    ManagedObject(package().data_pool),
>     _pool_ptr(pool_ptr), _conn(connect)
>  {
>     int ret;
> diff --git a/src/VolumeWrap.cpp b/src/VolumeWrap.cpp
> index fcda96e..59b21d8 100644
> --- a/src/VolumeWrap.cpp
> +++ b/src/VolumeWrap.cpp
> @@ -16,7 +16,7 @@ VolumeWrap::VolumeWrap(PoolWrap *parent,
>                        virStorageVolPtr volume_ptr,
>                        virConnectPtr connect):
>     PackageOwner<PoolWrap::PackageDefinition>(parent),
> -    ManagedObject(package().data_Volume),
> +    ManagedObject(package().data_volume),
>     _volume_ptr(volume_ptr), _conn(connect),
>     _lvm_name(""), _has_lvm_child(false),
>     _wrap_parent(parent)
> diff --git a/src/libvirt-schema.xml b/src/libvirt-schema.xml
> index a1b88e1..6fbca76 100644
> --- a/src/libvirt-schema.xml
> +++ b/src/libvirt-schema.xml
> @@ -7,7 +7,7 @@
>
>   <!-- In libvirt this is really the 'Connect' class, I may end up changing it.. -->
>
> -  <class name="Node">
> +  <class name="node">
>     <property name="hostname" type="sstr" access="RC" desc="Host name" index="y"/>
>     <property name="uri" type="sstr" access="RC" desc="URI of libvirt"/>
>     <property name="libvirtVersion" type="sstr" access="RC" desc="Version of libvirt on the managed node"/>
> @@ -54,7 +54,7 @@
>     </method>
>   </class>
>
> -  <class name="Domain">
> +  <class name="domain">
>     <property name="uuid" access="RC" type="sstr" desc="Domain UUID" index="y"/>
>     <property name="name" access="RC" type="sstr" desc="Domain name" index="y"/>
>     <property name="id" type="int64" desc="Hypervisor Domain id, -1 if not running."/>
> @@ -109,7 +109,7 @@
>     </method>
>   </class>
>
> -  <class name="Pool">
> +  <class name="pool">
>     <property name="uuid" access="RC" type="sstr" desc="Pool UUID" index="y"/>
>     <property name="name" access="RC" type="sstr" desc="Pool name" index="y"/>
>     <property name="parentVolume" access="RC" type="sstr" desc="If this pool is an LVM pool, this will contain the parent volume path."/>
> @@ -154,7 +154,7 @@
>
>   </class>
>
> -  <class name="Volume">
> +  <class name="volume">
>     <property name="key" type="sstr" access="RC" desc="Storage volume key" index="y"/>
>     <property name="path" type="sstr" access="RC" desc="Storage volume path" index="y"/>
>     <property name="name" type="sstr" access="RC" desc="Storage volume name" index="y"/>
>
> _______________________________________________
> Matahari mailing list
> Matahari lists fedorahosted org
> https://fedorahosted.org/mailman/listinfo/matahari
>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]