[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 21/27] node_device: avoid implicit int



2011/7/8 Eric Blake <eblake redhat com>:
> 'unsigned a' and 'unsigned int a' are synonyms, but we generally
> always spell out the 'int' in that case.  Fixing this will avoid
> a false positive in the next syntax-check commit.
>
> * src/conf/node_device_conf.h (pci_config_address)
> (_virNodeDevCapsDef): Prefer 'unsigned int' over 'unsigned'.
> ---
>
> v2: new patch.
> I didn't add a syntax check for implicit int, though, as we have a
> lot of other cases of that.  Rather, this was the only hit when
> grepping for 'unsigned flags'.
>
>  src/conf/node_device_conf.h |   58 +++++++++++++++++++++---------------------
>  1 files changed, 29 insertions(+), 29 deletions(-)

ACK.

-- 
Matthias Bolte
http://photron.blogspot.com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]