[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 15/27] uml: reject unknown flags

On 07/13/2011 03:14 PM, Eric Blake wrote:
>> Don't get fooled by the ATTRIBUTE_UNUSED again. All *DomainGetXMLDesc
>> use virDomainDefFormat and have to accept all flags that
>> virDomainDefFormat accepts. I suggest to recheck your series for this
>> pattern, here it's just the first time that I notice it.
> Ouch.  Good catch, and I'll have to fix that shortly.  I'll post the
> patch before I commit it, but it should be considered a trivial
> regression fix, so I'll commit it without waiting for review.

Thanks for making me audit all the drivers one more time.  It turns out
that none of the other drivers committed thus far had this problem
(rather, their problem was that virDomainGetXMLDesc didn't have any
virCheckFlags in the first place) - for example, libxlDomainGetXMLDesc.
 So without a regression, I can't claim the trivial rule any more, and
will just add the new patch to my v3 series.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]