[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 27/27] build: add syntax check for proper flags use

On 07/13/2011 09:23 AM, Eric Blake wrote:
> Therefore, my conclusion is that we can't change any existing command
> lines, but can only add new ones.  Adding new could include using "0x"
> or "0" prefixes (the old code output decimal, so it is distinguishable,
> and the new iohelper command line would then be that much easier to
> understand if you browse /proc/nnn/ to learn the command line that
> iohelper is using).
>>>         virCommandAddArgFormat(cmd, "%d", mode);
>> Same comment applies here about mode and switching from %d to %o.
> I'll look into that, as a separate patch.

I ended up deleting that line instead:


Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]