[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/8] save: wire up trivial saveFlags implementations

On 07/14/2011 08:24 AM, Eric Blake wrote:
> For all hypervisors that support save, the new API now performs
> the same functions as the old.
> * src/libxl/libxl_driver.c (libxlDomainSave): Move guts...
> (libxlDomainSaveFlags): ...to new function.
> * src/test/test_driver.c (testDomainSave, testDomainSaveFlags):
> Likewise.
> * src/vbox/vbox_tmpl.c (vboxDomainSave, vboxDomainSaveFlags):
> Likewise.

VBox virDomainSave doesn't work (it doesn't honor the destination file
name), and worse has no counterpart virDomainRestore (making it
absolutely worthless!).  I will split this patch to instead remove
vbox's virDomainSave, instead of wrapping it.  Or maybe we'll change
vbox's save to instead serve as virDomainManagedSave.  But the end
result is that is should not be part of this patch.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]