[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] add virCond into _virStoragePoolObj

On 07/11/2011 11:40 PM, Dave Allan wrote:
On Mon, Jul 11, 2011 at 06:11:47PM +0800, Guannan Ren wrote:
On 07/11/2011 04:49 PM, Jiri Denemark wrote:
On Sun, Jul 10, 2011 at 22:29:03 +0800, Guannan Ren wrote:
The three patches add support to delete volumes while it is building intead of raising
an warning infomation,then abort.
For the volume of raw file, delete it directly without any effect on the thread of creating
For the volume of block, wait for its finish , then delete it.
Hmm, shouldn't we cancel volume creation instead of waiting for it to finish?

        Yes, that is expected, but for volumes in pools of disk and
logical type, it is
     comparatively safe way to delete after its finish as the
creation of these volume
     is changing the files system or something low-level.
No, IMO, we really need to figure out if the operation is something
that can be cancelled, and if so, cancel it.


    There is a version 2 of patches.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]