[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 5/8] undefine: Implement internal API for libxl driver



于 2011年07月19日 02:43, Eric Blake 写道:
On 07/18/2011 01:53 AM, Osier Yang wrote:
This is just similiar as changes on qemu driver.

* src/libxl/libxl_driver.c: New callback for libxl_driver,
new function libxlDomainUndefineFlags, and changes libxlDomainUndefine
as a wrapper of libxlDomainUndefineFlags.
---
  src/libxl/libxl_driver.c |   34 +++++++++++++++++++++++++++++++++-
  1 files changed, 33 insertions(+), 1 deletions(-)

ACK.

+    char *name = NULL;
      int ret = -1;

+    virCheckFlags(VIR_DOMAIN_UNDEFINE_MANAGED_SAVE, -1);

Oh, here you went with MANAGED_SAVE, instead of MANAGED_STATE in patch 4/8 v3. Double check that each patch in your series compiles cleanly before pushing.


I'm creating a whole v4 series (without the patch for virsh dominfo), in case of I miss
something again, I'm always careless. :(

Osier


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]