[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 3/6] undefine: Implement internal API for qemu driver



On 07/19/2011 09:57 AM, Osier Yang wrote:
* src/qemu/qemu_driver.c: New call back for qemu_driver,
New function qemudDomainUndefineFlags, and changes on
qemudDomainUndefine.
---
  src/qemu/qemu_driver.c |   36 +++++++++++++++++++++++++++++++++++-
  1 files changed, 35 insertions(+), 1 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 8870e33..1af5e1a 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -4311,12 +4311,18 @@ cleanup:
      return dom;
  }

-static int qemudDomainUndefine(virDomainPtr dom) {
+static int
+qemudDomainUndefineFlags(virDomainPtr dom,
+                         unsigned int flags)

s/qemudDomain/qemuDomain/

@@ -4363,6 +4390,12 @@ cleanup:
  }

  static int
+qemudDomainUndefine(virDomainPtr dom)
+{
+    return qemudDomainUndefineFlags(dom, 0);

Likewise.

+}
+
+static int
  qemuDomainAttachDeviceDiskLive(struct qemud_driver *driver,
                                 virDomainObjPtr vm,
                                 virDomainDeviceDefPtr dev)
@@ -8553,6 +8586,7 @@ static virDriver qemuDriver = {
      .domainCreateWithFlags = qemudDomainStartWithFlags, /* 0.8.2 */
      .domainDefineXML = qemudDomainDefine, /* 0.2.0 */
      .domainUndefine = qemudDomainUndefine, /* 0.2.0 */
+    .domainUndefineFlags = qemudDomainUndefineFlags, /* 0.9.4 */

Then update both of these lines to use the shorter spelling.

ACK with that name change (we've been slowly migrating to the shorter name as we touch various APIs).

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]