[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 17/8] save: support direct autostart in qemu.conf



On Mon, Jul 18, 2011 at 09:45:34AM -0600, Eric Blake wrote:
> When auto-starting a domain on libvirtd startup, let the user
> configure whether to have the VIR_DOMAIN_START_DIRECT flag effect.
> 
> * src/qemu/qemu.conf (auto_start_direct): Document new variable.
> * src/qemu/libvirtd_qemu.aug (vnc_entry): Let augeas parse it.
> * src/qemu/qemu_conf.h (qemud_driver): Store new preference.
> * src/qemu/qemu_conf.c (qemudLoadDriverConfig): Parse it.
> * src/qemu/qemu_driver.c (qemuAutostartDomain): Honor it.
> ---
> 
> Might be worth combining with 9/8.
> 
>  src/qemu/libvirtd_qemu.aug |    1 +
>  src/qemu/qemu.conf         |    8 ++++++++
>  src/qemu/qemu_conf.c       |    4 ++++
>  src/qemu/qemu_conf.h       |    2 ++
>  src/qemu/qemu_driver.c     |    4 ++--
>  5 files changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug
> index dea6770..a78cd10 100644
> --- a/src/qemu/libvirtd_qemu.aug
> +++ b/src/qemu/libvirtd_qemu.aug
> @@ -42,6 +42,7 @@ module Libvirtd_qemu =
>                   | str_entry "dump_image_format"
>                   | str_entry "auto_dump_path"
>                   | bool_entry "auto_dump_direct"
> +                 | bool_entry "auto_start_direct"
>                   | str_entry "hugetlbfs_mount"
>                   | bool_entry "relaxed_acs_check"
>                   | bool_entry "vnc_allow_host_audio"

Again, flag naming question.

ACK with that resolved

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]