[libvirt] [PATCH v2] rpc: Make the dispatch generator handle 'void name(void)' style procedures

Eric Blake eblake at redhat.com
Thu Jul 21 13:39:50 UTC 2011


On 07/21/2011 05:58 AM, Matthias Bolte wrote:
> The only 'void name(void)' style procedure in the protocol is 'close' that
> is handled special, but also programming errors like a missing _args or
> _ret suffix on the structs in the .x files can create such a situation by
> accident. Making the generator aware of this avoids bogus errors from the
> generator such as:
>
>    Use of uninitialized value in exists at ./rpc/gendispatch.pl line 967.
>
> Also this allows to get rid of the -c option and the special case code for
> the 'close' procedure, as the generator handles it now correctly.
>
> Reported by Michal Privoznik
> ---
>
> v2:
> - remove the special handling of the 'close' procedure
>
>   daemon/Makefile.am     |    2 +-
>   src/Makefile.am        |    2 +-
>   src/rpc/gendispatch.pl |   32 +++++++++++++++++---------------
>   3 files changed, 19 insertions(+), 17 deletions(-)

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list