[libvirt] [PATCH v2 12/13] destroy: Implement internal API for xen driver

[Eric Blake]

On 07/21/2011 10:08 AM, Michal Privoznik wrote:
> ---
>   src/xen/xen_driver.c     |   28 ++++++++++++++++++++++++++++
>   src/xen/xen_driver.h     |    1 +
>   src/xen/xen_hypervisor.c |   24 ++++++++++++++++++++++--
>   src/xen/xen_hypervisor.h |    3 +++
>   src/xen/xen_inotify.c    |    1 +
>   src/xen/xend_internal.c  |   24 ++++++++++++++++++++++--
>   src/xen/xm_internal.c    |    1 +
>   src/xen/xs_internal.c    |    1 +
>   8 files changed, 79 insertions(+), 4 deletions(-)

This is overkill for now.  You could have confined your patch to just 
src/xen/xen_driver.c, which checks that flags is 0, then calls the 
non-flag version of all the secondary drivers, rather than adding a flag 
version to all secondary drivers.

On the other hand, if we ever do add flags, and want to support those 
flags in a secondary xen driver (that is, supposing libxl doesn't take 
over all things xen), then this already gives us the infrastructure to 
do so.  So I'm okay with it as is.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org