[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 0/4] support the listenNetwork attribute in <graphics>



On 07/22/2011 04:37 AM, Daniel P. Berrange wrote:
The 'listenNetwork' attribute would solve the second, but do
nothing to solve the first.

I think we ought to thus use a subelement

    <graphics>
      <listen type='network' network='foo'/>
    </graphics>

    <graphics>
      <listen type='address' address='192.168.122.122'/>
      <listen type='address' address='10.0.0.1'/>
      <listen type='address' address='fec0:1:2::232'/>

And instead of listenNetwork, this would be:

   <listen type='network' name='netname'/>

    </graphics>

Of course, for back-compat reasons, the first <listen> tag with an address (and not a network name) should _also_ populate the listen='' attribute of <graphics>. So, just like we did for networks, a single listen address can be specified in one or both locations on input, but is shown in both on output, and the new listen-network uses only the new sub-element style.

I like the idea, and do think it's more flexible, if qemu ever learns to support multiple interfaces.

Yes, I know QEMU does not support listening on multiple addresses
yet, but QEMU really needs to be fixed in that respect. This
shouldn't stop us from structuring the XML nicely now.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]