[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] SASL: Introduce session mutex

On 07/25/2011 01:04 PM, Michal Privoznik wrote:
Some of SASL interacting functions can be called within two or more
threads with the same pointer. Therefore we need to protect
virNetSASLSessionPtr with mutex to avoid non-consistent states.

Looks like you and danpb had the same idea at roughly the same time. His patch appears more complete (you're missing a mutex on one of the structs), but since I'm severely sleep-deprived at the moment, I'm going to refrain from ACKing either one, as I may miss some problem.

Here's Dan's version (does both SASL and TLS in one go) (I'm pointing it out here because I've already ACKed the other patches in that same series, and wanted to make sure this one didn't get lost in the sea of other replies):


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]