[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 05/10] qemu: Remove special case for virDomainGetBlockInfo



On 07/22/2011 03:10 PM, Eric Blake wrote:
On 07/18/2011 06:27 PM, Jiri Denemark wrote:
Like other query commands, this can now be called directly during
migration.
---
src/qemu/qemu_domain.h | 4 ----
src/qemu/qemu_driver.c | 42 ++++++++++++------------------------------
src/qemu/qemu_migration.c | 14 --------------
3 files changed, 12 insertions(+), 48 deletions(-)

ACK. In fact, it might be possible to shuffle the series and push this
even before the new MIGRATE_CHANGE_PROTECTION stuff, although I haven't
tried that yet.

I've tried it now. This patch can be shuffled, but some of the other cleanups cannot (patch 7/10 introduced QEMU_JOB_MIGRATION_OP and used it in code added earlier by patch 1/10), so I'm not going to do any shuffling.

On IRC, danpb told me that he tested the 10 patches as-is with no failures on the libvirt-tck migration behemoth (over 900 tests, with all sorts of cross-compatibility checking), but that he still needed to test my changes to patch 3/10. Once that completes, and he decides whether to ACK my changes, we can get this series pushed, hopefully before 0.9.4-RC2 is built (this series definitely fits in the release, as it is fixing a safety bug without adding any new API, just a new bit to an existing API).

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]