[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv4 1/2] conf: add <listen> subelement to domain <graphics> element

On 07/28/2011 12:11 AM, Laine Stump wrote:
Once it's plugged in, the<listen>  element will be an optional
replacement for the "listen" attribute that graphics elements already
have. If the<listen>  element is type='address', it will have an
attribute called 'address' which will contain an IP address or dns
name that the guest's display server should listen on. If, however,
type='network', the<listen>  element should have an attribute called
'network' that will be set to the name of a network configuration to
get the IP address from.

I think we're there.  Thanks for putting up with the review churn.

+++ b/docs/formatdomain.html.in
@@ -2046,6 +2046,12 @@ qemu-kvm -net nic,model=? /dev/null
      &lt;graphics type='vnc' port='5904'/&gt;

It looks fishy to have one...

      &lt;graphics type='rdp' autoport='yes' multiUser='yes' /&gt;
      &lt;graphics type='desktop' fullscreen='yes'/&gt;
+&lt;graphics type='vnc'&gt;
+&lt;listen type='address' address=''/&gt;

...and then a second type='vnc' description (do we support multiple vnc graphics adapters on any existing hypervisor?). How about consolidating this part of the example into just:

      &lt;graphics type='vnc' port='5904'&gt;
        &lt;listen type='address' address=''/&gt;

+<dd>if<code>type='address'</code>, the<code>address</code>
+        attribute will contain either an IP address or hostname (which
+        will be resolved to an IP address via a DNS query) to listen
+        on. In the "live" XML of a running domain, this attribute be

s/be/will be/

ACK with those nits fixed, no v5 needed.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]