[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] tests: Unify style of test skipping code



On 07/28/2011 09:52 AM, Matthias Bolte wrote:
Prefer 'return EXIT_AM_SKIP' over 'exit(EXIT_AM_SKIP)'.

Prefer 'int main(void)' over 'int main(int argc, char **argv)'.

Fix mymain signature in commandtest and nodeinfotest.
---
  tests/commandtest.c          |   10 +++++-----
  tests/nodeinfotest.c         |   10 +++++-----
  tests/qemuargv2xmltest.c     |    6 +++++-
  tests/qemuxml2xmltest.c      |    6 +++++-
  tests/virnettlscontexttest.c |    6 ++++--
  tests/virshtest.c            |   26 +++++++++++++++++---------
  6 files changed, 41 insertions(+), 23 deletions(-)

ACK, all cosmetic, so no problem pushing prior to 0.9.4.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]