[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Use common parameter order for remote(De)SerializeTypedParameters



2011/5/31 Eric Blake <eblake redhat com>:
> On 05/30/2011 12:33 PM, Matthias Bolte wrote:
>> We commonly use "value, length" order, let's stick to this.
>> ---
>>  daemon/remote.c            |   40 ++++++++++++++++++++--------------------
>>  src/remote/remote_driver.c |   40 ++++++++++++++++++++--------------------
>>  2 files changed, 40 insertions(+), 40 deletions(-)
>
> ACK.  (Does it show that I built up the factored function incrementally,
> without realizing that the end result ended up going against convention?)
>

You might also just have matched the XDR on-the-wire ordering of arrays :)

Thanks, pushed.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]