[libvirt] [PATCH] remote generator: Handle some virTypedParameterPtr using functions
Matthias Bolte
matthias.bolte at googlemail.com
Wed Jun 1 16:32:21 UTC 2011
2011/5/31 Eric Blake <eblake at redhat.com>:
> On 05/30/2011 12:34 PM, Matthias Bolte wrote:
>> This doesn't cover the getters that allow to query nparams yet.
>> ---
>>
>> This patch depends on
>>
>> https://www.redhat.com/archives/libvir-list/2011-May/msg01856.html
>>
>> daemon/remote.c | 182 -----------------------------------
>> daemon/remote_generator.pl | 58 +++++++++++-
>> src/remote/remote_driver.c | 215 ------------------------------------------
>> src/remote/remote_protocol.x | 20 ++--
>> 4 files changed, 67 insertions(+), 408 deletions(-)
>
> Nice reduction in maintained code size!
>
> I got conflicts when trying this patch out, though, so you may have some
> rebase issues, but I think I resolved it correctly, and was able to
> verify that with this applied, the generated functions accurately
> replace the manual versions.
You might have missed one of the previous patches, because It applies
without problem for me.
> ACK.
Thanks, pushed.
Matthias
More information about the libvir-list
mailing list