[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix QEMU XML-2-ARGV graphics-spice-timeout test



2011/6/1 Eric Blake <eblake redhat com>:
> On 06/01/2011 10:13 AM, Matthias Bolte wrote:
>> The test used an emulator that is not supported in testutilsqemu.c.
>> Swicth from qemu-kvm to kvm to fix this.
>
> s/Swicth/Switch/

My typo rate is quite high recently.

>> ---
>>
>> This patch addresses the problem discussed here:
>> https://www.redhat.com/archives/libvir-list/2011-May/msg01914.html
>>
>>  .../qemuxml2argv-graphics-spice-timeout.args       |    2 +-
>>  .../qemuxml2argv-graphics-spice-timeout.xml        |    2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> Given the contents of tests/testutilsqemu.c, this works (that file
> provides both /usr/bin/qemu and /usr/bin/kvm definitions).  A larger
> patch, but one which would prevent future issues of this sort, would be
> modifying that file to also provide a /usr/bin/qemu-kvm definition.
>
> In the interest of getting 0.9.2 ready, though, I favor the smaller
> patch for now.
>
> ACK.

Thanks. pushed.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]